Move asset hashing into the CLI #3988
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
cli
ealmloff
commented
May 26, 2025
|
|
||
| #[derive(Clone, Debug, Parser)] | ||
| pub struct BuildAssets { | ||
| /// The source executable to build assets for. | ||
| pub(crate) executable: PathBuf, | ||
|
|
||
| /// The source directory for the assets. | ||
| pub(crate) source: PathBuf, |
There was a problem hiding this comment.
The path this is joined against is always absolute, so setting this argument makes no difference
|
This PR is now modifying the final executable and resigning it on MacOS. Windows and Ubuntu platforms worked without needing a signature when I tested them |
ealmloff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #3705
Fixes #3467
Fixes #3918
Stacked on #4042